Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Select): disabled for options #7622

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix(Select): disabled for options #7622

merged 1 commit into from
Sep 19, 2024

Conversation

SevereCloud
Copy link
Contributor

Описание

disabled не прокидывается в option

Изменения

Прокидываем disabled в option

Release notes

Исправления

  • Select: disabled для опций не прокидывалось в NativeSelect

@SevereCloud
fix(Select): disabled for options
f611517 
disabled не прокидывается в option
@SevereCloud SevereCloud requested a review from a team as a code owner September 18, 2024 09:57
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 385.54 KB (+0.01% 🔺)
JS (gzip) 116.58 KB (+0.01% 🔺)
JS (brotli) 95.7 KB (-0.07% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.84 KB (0%)
CSS (gzip) 41.39 KB (0%)
CSS (brotli) 32.86 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit f611517

@BlackySoul
Copy link
Contributor

Скриншот зафлакал, но, кажется, что к изменениям не имеет отношения х)

@SevereCloud SevereCloud self-assigned this Sep 19, 2024
@SevereCloud SevereCloud added patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v6 Автоматизация: PR продублируется в ветку v6 labels Sep 19, 2024
@SevereCloud SevereCloud added this to the v6.7.1 milestone Sep 19, 2024
@SevereCloud SevereCloud merged commit 1ebfe43 into master Sep 19, 2024
26 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/Select/disabled-for-options branch September 19, 2024 07:31
vkcom-publisher pushed a commit that referenced this pull request Sep 19, 2024
@SevereCloud @actions-user
fix(Select): disabled for options (#7622)
dad389a 
disabled не прокидывается в option
vkcom-publisher pushed a commit that referenced this pull request Sep 19, 2024
@SevereCloud @actions-user
fix(Select): disabled for options (#7622)
a8ec2f5 
disabled не прокидывается в option
@vkcom-publisher
Copy link
Contributor

✅ v6.7.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@BlackySoul BlackySoul BlackySoul approved these changes

Assignees

@SevereCloud SevereCloud

Labels
patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v6 Автоматизация: PR продублируется в ветку v6
Projects
VKUI
Archived in project
Milestone
v6.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@SevereCloud @BlackySoul @vkcom-publisher @andrey-medvedev-vk