Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(TabsItem): gaps use first-child #7629

Merged
merged 1 commit into from
Sep 20, 2024
Merged

fix(TabsItem): gaps use first-child #7629

merged 1 commit into from
Sep 20, 2024

Conversation

SevereCloud
Copy link
Contributor

@SevereCloud SevereCloud commented Sep 19, 2024 •
edited
Loading

Описание

TabsItem при использовании разных тегов(используя свойства href и onClick) могли не проставляться отступы между элементами

image

Изменения

Используем first-child вместо first-of-type

Release notes

Исправления

  • TabsItem: исправлен отступ между элементами при использовании href и onClick вместе

@SevereCloud SevereCloud requested a review from a team as a code owner September 19, 2024 14:19
@SevereCloud SevereCloud self-assigned this Sep 19, 2024
@SevereCloud SevereCloud added type:bug cmp:tabs-item patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча v6 Автоматизация: PR продублируется в ветку v6 labels Sep 19, 2024
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 385.23 KB (0%)
JS (gzip) 116.48 KB (0%)
JS (brotli) 95.64 KB (0%)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.19 KB (-0.01% 🔽)
CSS (gzip) 41.31 KB (+0.01% 🔺)
CSS (brotli) 32.75 KB (+0.04% 🔺)

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit b156e9a

@SevereCloud SevereCloud merged commit e98a9e4 into master Sep 20, 2024
25 of 26 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/fix/TabsItem/gaps-use-first-child branch September 20, 2024 08:16
vkcom-publisher pushed a commit that referenced this pull request Sep 20, 2024
@SevereCloud @actions-user
fix(TabsItem): gaps use first-child (#7629)
0953237
vkcom-publisher pushed a commit that referenced this pull request Sep 20, 2024
@SevereCloud @actions-user
fix(TabsItem): gaps use first-child (#7629)
bf0a093
@inomdzhon inomdzhon added this to the v6.7.1 milestone Sep 20, 2024
@vkcom-publisher
Copy link
Contributor

✅ v6.7.1 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@BlackySoul BlackySoul BlackySoul approved these changes

Assignees

@SevereCloud SevereCloud

Labels
cmp:tabs-item patch Автоматизация: PR продублируется в ветку последнего минорного релиза для выпуска патча type:bug v6 Автоматизация: PR продублируется в ветку v6
Projects
VKUI
Archived in project
Milestone
v6.7.1
Development

Successfully merging this pull request may close these issues.
5 participants
@SevereCloud @vkcom-publisher @BlackySoul @andrey-medvedev-vk @inomdzhon