Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Spacing): remove 3xs size type #7634

Merged
merged 1 commit into from
Sep 20, 2024
Merged

feat(Spacing): remove 3xs size type #7634

merged 1 commit into from
Sep 20, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Sep 20, 2024 •
edited by inomdzhon
Loading

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас в некоторых местах в css используется токен --vkui--spacing_size_3xs, но этот токен устарел и равен токену --vkui--spacing_size_2xs. Нужно избавиться от использования этого токена в css

Изменения

  • Выпилил использование этого токена в компоненте Spacing, соответственно удалил один из вариантов пропа size
  • Реализовал кодмод, чтобы size: 3xs преобразовывался в 2xs в Spacing.
  • Заменил использование токена --vkui--spacing_size_3xs на --vkui--spacing_size_2xs в css компонента Header

Release notes

BREAKING CHANGE

  • Spacing: удален вариант значения пропа size 3xs вместо него можно использовать 2xs, он такой же по значению 
    - <Spacing size="3xs" />
+ <Spacing size="2xs" />

@EldarMuhamethanov EldarMuhamethanov added this to the v7.0.0-beta.0 milestone Sep 20, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Sep 20, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner September 20, 2024 11:47
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 385.21 KB (-0.01% 🔽)
JS (gzip) 116.48 KB (-0.01% 🔽)
JS (brotli) 95.62 KB (-0.03% 🔽)
JS import Div (tree shaking) 1.45 KB (0%)
CSS 330.12 KB (-0.03% 🔽)
CSS (gzip) 41.3 KB (-0.03% 🔽)
CSS (brotli) 32.74 KB (-0.04% 🔽)

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

Playwright Report

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit 1e6dcad

@inomdzhon inomdzhon merged commit 491772f into master Sep 20, 2024
25 of 26 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/remove-spacing-size-3xs branch September 20, 2024 14:45
@vkcom-publisher
Copy link
Contributor

✅ v7.0.0-beta.0 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.0, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

✅ v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
breaking-change cmp:spacing
Projects
VKUI
Archived in project
Milestone
v7.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@EldarMuhamethanov @vkcom-publisher @inomdzhon @andrey-medvedev-vk