Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rm BEM #7655

Merged
merged 3 commits into from
Sep 26, 2024
Merged

feat: rm BEM #7655

merged 3 commits into from
Sep 26, 2024

Conversation

SevereCloud
Copy link
Contributor


Описание

Удаляем BEM

Release notes

@SevereCloud SevereCloud requested a review from a team as a code owner September 24, 2024 10:33
Copy link
Contributor

github-actions bot commented Sep 24, 2024

size-limit report 📦

Path Size
JS 385.32 KB (+0.1% 🔺)
JS (gzip) 116.61 KB (+0.15% 🔺)
JS (brotli) 95.78 KB (+0.09% 🔺)
JS import Div (tree shaking) 1.46 KB (+0.81% 🔺)
CSS 331.15 KB (+0.26% 🔺)
CSS (gzip) 41.51 KB (+0.44% 🔺)
CSS (brotli) 32.9 KB (+0.45% 🔺)

Copy link

codesandbox-ci bot commented Sep 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Sep 24, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Sep 24, 2024

👀 Docs deployed

Commit 08bbddf

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 97.73463% with 7 lines in your changes missing coverage. Please review.

Project coverage is 95.16%. Comparing base (c96f0b6) to head (08bbddf).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...components/PanelHeaderButton/PanelHeaderButton.tsx 40.00% 3 Missing ⚠️
...src/components/FormLayoutGroup/FormLayoutGroup.tsx 66.66% 1 Missing ⚠️
packages/vkui/src/components/Group/GroupHeader.tsx 0.00% 1 Missing ⚠️
packages/vkui/src/components/Header/Header.tsx 90.00% 1 Missing ⚠️
.../components/RichCell/RichCellIcon/RichCellIcon.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7655      +/-   ##
==========================================
+ Coverage   95.13%   95.16%   +0.02%     
==========================================
  Files         383      383              
  Lines       11347    11333      -14     
  Branches     3726     3714      -12     
==========================================
- Hits        10795    10785      -10     
+ Misses        552      548       -4     
Flag Coverage Δ
unittests 95.16% <97.73%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SevereCloud SevereCloud force-pushed the SevereCloud/feat/rm-BEM branch from 2f5726a to 85c6ceb Compare September 24, 2024 10:42
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

docs/CSS_GUIDE.md Outdated Show resolved Hide resolved
docs/CSS_GUIDE.md Outdated Show resolved Hide resolved
docs/CSS_GUIDE.md Outdated Show resolved Hide resolved
inomdzhon
inomdzhon previously approved these changes Sep 24, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note

Нужно описать Realese notes с BREAKING CHANGE в описании PR, чтобы те, кто снаружи завязываются на классы, были предупреждены

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Круто!

Ещё не всё просмотрел, но решил пораньше спросить по поводу некоторого удалённого css.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

inomdzhon
inomdzhon previously approved these changes Sep 25, 2024
@inomdzhon
Copy link
Contributor

Note

Нужно описать Realese notes с BREAKING CHANGE в описании PR, чтобы те, кто снаружи завязываются на классы, были предупреждены

зафигачишь плиз релиз ноуте до мержа 🙏

SevereCloud and others added 3 commits September 26, 2024 10:17
Co-authored-by: Inomdzhon Mirdzhamolov <i.mirdzhamolov@vk.team>
@SevereCloud SevereCloud merged commit dd58b57 into master Sep 26, 2024
28 checks passed
@SevereCloud SevereCloud deleted the SevereCloud/feat/rm-BEM branch September 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE][Enhancement] Реструктурируем CSS
3 participants