Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Separator): rename mode to appearance #7687

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

BlackySoul
Copy link
Contributor

  • Unit-тесты
  • Release notes

Описание

mode не подходит для изменения цветовой палитры, используем appearance

Release notes

BREAKING CHANGE

  • Separator: свойство mode заменено на appearance

    <Separator
    -  mode="primary"
    +  appearance="primary"
    />

@BlackySoul BlackySoul added this to the v7.0.0-beta.0 milestone Oct 1, 2024
@BlackySoul BlackySoul self-assigned this Oct 1, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner October 1, 2024 08:49
Copy link
Contributor

github-actions bot commented Oct 1, 2024

size-limit report 📦

Path Size
JS 385.45 KB (+0.01% 🔺)
JS (gzip) 116.65 KB (+0.02% 🔺)
JS (brotli) 95.86 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 331.3 KB (+0.01% 🔺)
CSS (gzip) 41.53 KB (+0.01% 🔺)
CSS (brotli) 32.91 KB (-0.11% 🔽)

Copy link

codesandbox-ci bot commented Oct 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 1, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Oct 1, 2024

👀 Docs deployed

Commit 6ae5145

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.16%. Comparing base (5459b15) to head (6ae5145).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7687   +/-   ##
=======================================
  Coverage   95.16%   95.16%           
=======================================
  Files         383      383           
  Lines       11335    11335           
  Branches     3714     3714           
=======================================
  Hits        10787    10787           
  Misses        548      548           
Flag Coverage Δ
unittests 95.16% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BlackySoul BlackySoul merged commit 0017fb8 into master Oct 1, 2024
28 checks passed
@BlackySoul BlackySoul deleted the blackysoul/fix_separator_mode branch October 1, 2024 09:02
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.0 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.0, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants