Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Placeholder): rename prop header to title. Subcomponent Header to Title, Text to Description #7766

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 16, 2024


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

Для компонента Placeholder переименовал свойство header наtitle. А также переименовал подкомпоненты Header на Title, Text на Description

Release notes

BREAKING CHANGE

  • Placeholder:
    • свойство header переименовано на title
      <Placeholder
        icon={<Icon56UsersOutline />}
      - header={<Button size="m">Подключить сообщества</Button>}
      + title={<Button size="m">Подключить сообщества</Button>}
      >
        Подключите сообщества, от которых Вы хотите получать уведомления
      </Placeholder>
    • подкомпонент Header переименован на Title, Text переименован на Description
      <Placeholder.Container>
      - <Placeholder.Header>
      + <Placeholder.Title>
          Find friends
      -  </Placeholder.Header>
      +  </Placeholder.Title>
      -  <Placeholder.Text>
      +  <Placeholder.Description>
          The people you add as your friends will be displayed here
      -  </Placeholder.Text>
      +  </Placeholder.Description>
      </Placeholder.Container>

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 16, 2024 08:37
Copy link
Contributor

github-actions bot commented Oct 16, 2024

size-limit report 📦

Path Size
JS 386.28 KB (+0.01% 🔺)
JS (gzip) 116.88 KB (+0.01% 🔺)
JS (brotli) 96.04 KB (+0.07% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.27 KB (+0.01% 🔺)
CSS (gzip) 41.78 KB (+0.02% 🔺)
CSS (brotli) 33.12 KB (+0.06% 🔺)

Copy link

codesandbox-ci bot commented Oct 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 03eac81

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (975878d) to head (03eac81).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7766   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11354    11354           
  Branches     3724     3724           
=======================================
  Hits        10803    10803           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon merged commit 96fcb5a into master Oct 21, 2024
28 checks passed
@inomdzhon inomdzhon deleted the e.muhamethanov/7759/placeholder-props-renaming branch October 21, 2024 09:02
@BlackySoul BlackySoul mentioned this pull request Nov 5, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] Placeholder: переименовать header -> title, text -> description
3 participants