Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Banner): rename typography props #7773

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 16, 2024


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

В компоненте Banner переименовал свойства: subhead -> subtitle, header -> title, extraSubhead -> extraSubtitle.
В компоненте FormStatus переименовал свойство header -> title, так как FormStatus тоже использует Banner

Release notes

BREAKING CHANGE

  • Banner:
    • переименовано свойство subheader -> subtitle
    • переименовано свойство text -> extraSubtitle
    • переименовано свойство header -> title
    <Banner
      before={<Avatar size={48} src={'user_lihachyov'} />}
    -  header="Сегодня день рождения Михаила Лихачёва"
    +  title="Сегодня день рождения Михаила Лихачёва"
    -  subheader="Подарите подарок"
    +  subtitle="Подарите подарок"
    -  text="Дополнительный текст"
    +  extraSubtitle="Дополнительный текст"
    />
  • FormStatus: переименовано свойство header -> title
    <FormStatus
    -  header="Некорректный мобильный номер"
    +  title="Некорректный мобильный номер"
      mode="error"
    >
      Необходимо корректно ввести номер в международном формате
    </FormStatus>

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 16, 2024 12:44
Copy link

codesandbox-ci bot commented Oct 16, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Oct 16, 2024

size-limit report 📦

Path Size
JS 386.3 KB (+0.01% 🔺)
JS (gzip) 116.88 KB (+0.01% 🔺)
JS (brotli) 96.01 KB (+0.05% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.27 KB (+0.01% 🔺)
CSS (gzip) 41.77 KB (0%)
CSS (brotli) 33.06 KB (-0.12% 🔽)

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit beff4fd

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (975878d) to head (beff4fd).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7773   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11354    11354           
  Branches     3724     3724           
=======================================
  Hits        10803    10803           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 84bbe43 into master Oct 17, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7772/banner-rename-props branch October 17, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants