Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ActionSheet): rename header to title, text to description #7785

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

В компоненте ActionSheet переименовал свойства header to title, text to description

Release notes

BREAKING CHANGE

  • ActionSheet:
    • свойство header переименовано на title
    • свойство text переименовано на description
      <ActionSheet
        onClose={() => {}}
      - header="Вы действительно хотите удалить это видео из Ваших видео?"
      + title="Вы действительно хотите удалить это видео из Ваших видео?"
      - text="Данное действие реально удалит видео, подумайте!"
      + description="Данное действие реально удалит видео, подумайте!"
      >
        <ActionSheetItem mode="destructive">Удалить видео</ActionSheetItem>
      </ActionSheet>

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 17, 2024 11:38
Copy link
Contributor

size-limit report 📦

Path Size
JS 386.5 KB (+0.01% 🔺)
JS (gzip) 116.91 KB (+0.01% 🔺)
JS (brotli) 96 KB (-0.06% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.52 KB (+0.01% 🔺)
CSS (gzip) 41.82 KB (+0.02% 🔺)
CSS (brotli) 33.09 KB (+0.07% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit d2d9fa0

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (2848015) to head (d2d9fa0).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7785   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11357    11357           
  Branches     3727     3727           
=======================================
  Hits        10806    10806           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EldarMuhamethanov EldarMuhamethanov merged commit 9af33b2 into master Oct 18, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7778/rename-action-sheet-props branch October 18, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] ActionSheet: переименовать header -> title, text -> description
3 participants