Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SimpleCell, MiniInfoCell, SubnavigationButton): rename expandable prop to chevron #7787

Merged

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 17, 2024


  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

Для компонента SimpleCell, MiniInfoCell, SubnavigationButton переименовал свойство expandable на chevron.

Release notes

BREAKING CHANGE

  • SimpleCell: свойство expandable переименовано на chevron
    <SimpleCell
      onClick={() => {}}
    - expandable="auto"
    + chevron="auto"
      indicator="При использовании"
    >
      Геолокация
    </SimpleCell>
  • Cell: свойство expandable переименовано на chevron
    <Cell
      onClick={() => {}}
    - expandable="auto"
    + chevron="auto"
      indicator="При использовании"
    >
      Геолокация
    </Cell>
  • CellButton: свойство expandable переименовано в chevron
    <CellButton
      onClick={() => {}}
    - expandable="auto"
    + chevron="auto"
      indicator="При использовании"
    >
      Геолокация
    </CellButton>
  • MiniInfoCell: свойство expandable переименовано на chevron
    <MiniInfoCell
      before={<Icon20WorkOutline />}
      mode="add"
      onClick={() => console.log('Указать место учёбы')}
      textWrap="short"
    - expandable
    + chevron
    >
      Укажите место учёбы
    </MiniInfoCell>
  • SubnavigationButton: свойство expandable переименовано на chevron
    <SubnavigationButton
    - expandable={true}
    + chevron={true}
      selected={true}
      onClick={() => {}}
    >
      Button
    </SubnavigationButton>

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner October 17, 2024 14:58
Copy link
Contributor

size-limit report 📦

Path Size
JS 386.54 KB (-0.01% 🔽)
JS (gzip) 116.92 KB (-0.01% 🔽)
JS (brotli) 95.98 KB (+0.02% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 333.53 KB (-0.01% 🔽)
CSS (gzip) 41.81 KB (-0.01% 🔽)
CSS (brotli) 33.13 KB (+0.18% 🔺)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.14%. Comparing base (e5c337d) to head (d059120).
Report is 18 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7787   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files         384      384           
  Lines       11357    11357           
  Branches     3727     3727           
=======================================
  Hits        10806    10806           
  Misses        551      551           
Flag Coverage Δ
unittests 95.14% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

👀 Docs deployed

Commit d059120

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@EldarMuhamethanov EldarMuhamethanov merged commit 5fc002c into master Oct 21, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7786/simple-cell-expandable-renaming branch October 21, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BREAKING CHANGE] SimpleCell: переименовать expandable -> chevron
3 participants