Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default a11y text #7821

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Oct 23, 2024

  • Release notes

Описание

Убираем текст по умолчанию, как договорились в обсуждении

Release notes

BREAKING CHANGE

  • ScreenSpinner: удалён a11y-текст по умолчанию, передавайте нужный текст в children или label свойства.

@BlackySoul BlackySoul added this to the v7.0.0-beta.2 milestone Oct 23, 2024
@BlackySoul BlackySoul self-assigned this Oct 23, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner October 23, 2024 17:10
Copy link
Contributor

size-limit report 📦

Path Size
JS 381.16 KB (-0.02% 🔽)
JS (gzip) 115.5 KB (-0.03% 🔽)
JS (brotli) 95.1 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.15 KB (0%)
CSS (gzip) 42.09 KB (0%)
CSS (brotli) 33.17 KB (0%)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit 8ee4f72

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.15%. Comparing base (06f771a) to head (8ee4f72).
Report is 5 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7821   +/-   ##
=======================================
  Coverage   95.15%   95.15%           
=======================================
  Files         377      377           
  Lines       11098    11098           
  Branches     3685     3685           
=======================================
  Hits        10560    10560           
  Misses        538      538           
Flag Coverage Δ
unittests 95.15% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@inomdzhon inomdzhon added a11y Доступность (цифровая) cmp:screen-spinner labels Oct 24, 2024
@inomdzhon inomdzhon merged commit 6760ba7 into master Oct 24, 2024
28 checks passed
@inomdzhon inomdzhon deleted the blackysoul/fix_screen_spinner_todo branch October 24, 2024 11:56
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.2 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.2, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Доступность (цифровая) cmp:screen-spinner
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants