Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SimpleCell): rename subhead to overTitle #7861

Merged
merged 3 commits into from
Oct 30, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

@EldarMuhamethanov EldarMuhamethanov commented Oct 28, 2024

  • Unit-тесты
  • e2e-тесты
  • Release notes
  • Codemod

Описание

В компоненте SimpleCell нужно переименовать проп subhead в overTitle

Release notes

BREAKING CHANGE

  • SimpleCell: свойство subhead переименовано в overTitle

    Пример миграции
    <SimpleCell
      onClick={() => {}}
    - subhead={"Subhead"}
    + overTitle={"Subhead"}
      indicator="При использовании"
    >
      Геолокация
    </SimpleCell>
  • Cell: свойство subhead переименовано в overTitle

    Пример миграции
    <Cell
      onClick={() => {}}
    - subhead={"Subhead"}
    + overTitle={"Subhead"}
      indicator="При использовании"
    >
      Геолокация
    </Cell>
  • CellButton: свойство subhead переименовано в overTitle

    Пример миграции
    <CellButton
      onClick={() => {}}
    - subhead={"Subhead"}
    + overTitle={"Subhead"}
      indicator="При использовании"
    >
      Геолокация
    </CellButton>

Copy link
Contributor

size-limit report 📦

Path Size
JS 378.38 KB (+0.01% 🔺)
JS (gzip) 114.62 KB (-0.01% 🔽)
JS (brotli) 94.37 KB (-0.05% 🔽)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 332.17 KB (+0.01% 🔺)
CSS (gzip) 42.12 KB (-0.01% 🔽)
CSS (brotli) 33.17 KB (-0.24% 🔽)

Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

Copy link
Contributor

👀 Docs deployed

Commit a4b90d1

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (e44a13f) to head (a4b90d1).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7861   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         376      376           
  Lines       11030    11030           
  Branches     3669     3669           
=======================================
  Hits        10498    10498           
  Misses        532      532           
Flag Coverage Δ
unittests 95.17% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@EldarMuhamethanov EldarMuhamethanov merged commit 1d765fd into master Oct 30, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/cell-subhead-to-overtitle branch October 30, 2024 08:35
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.2 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.2, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants