Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create useCSSTransition() #7876

Merged
merged 3 commits into from
Nov 5, 2024

Conversation

inomdzhon
Copy link
Contributor


  • Unit-тесты

Описание

По аналогии useCSSKeyframesAnimationController, а также на основе компонента CSSTransition из react-transitiong-group создал хук, чтобы можно было управлять переходами монтирования/размонитрования

Release notes

@inomdzhon inomdzhon requested a review from a team as a code owner November 1, 2024 11:00
Copy link
Contributor

github-actions bot commented Nov 1, 2024

size-limit report 📦

Path Size
JS 383.05 KB (0%)
JS (gzip) 122.55 KB (0%)
JS (brotli) 101.53 KB (0%)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

Copy link

codesandbox-ci bot commented Nov 1, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 1, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 1, 2024

👀 Docs deployed

Commit 7446099

Copy link

codecov bot commented Nov 1, 2024

Codecov Report

Attention: Patch coverage is 99.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.39%. Comparing base (ebb46a5) to head (93d235b).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
packages/vkui/src/lib/animation/index.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7876      +/-   ##
==========================================
+ Coverage   95.17%   95.39%   +0.22%     
==========================================
  Files         376      377       +1     
  Lines       11041    11042       +1     
  Branches     3664     3672       +8     
==========================================
+ Hits        10508    10534      +26     
+ Misses        533      508      -25     
Flag Coverage Δ
unittests 95.39% <99.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

SevereCloud
SevereCloud previously approved these changes Nov 5, 2024
packages/vkui/src/lib/animation/useCSSTransition.ts Outdated Show resolved Hide resolved
Co-authored-by: Daniil Suvorov <severecloud@gmail.com>
@inomdzhon inomdzhon merged commit 5640748 into master Nov 5, 2024
28 checks passed
@inomdzhon inomdzhon deleted the imirdzhamolov/feat/useCSSTransition branch November 5, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants