Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HorizontalScroll): fix scroll when mouse over arrow #7882

Merged
merged 1 commit into from
Nov 5, 2024
Merged

fix(HorizontalScroll): fix scroll when mouse over arrow #7882

merged 1 commit into from
Nov 5, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • Release notes

Описание

Сейчас при наведении на стрелки в компоненте HorizontalScroll не происходит скролл колесиком мыши.

Изменения

  • Сделал небольшой рефакторинг компонента HorizontalScroll, а именно избавился от подписок на события wheel и scroll через useEventListener. Теперь используется стандартный механизм React для подписки на события
  • Добавил обработчики wheel события на стрелках и обработал их, как событие wheel на scroll контейнере

Release notes

Исправления

  • HorizontalScroll: исправлена проблема с отсутствием скрола при наведении на стрелки

@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner November 2, 2024 10:07
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

size-limit report 📦

Path Size
JS 382.37 KB (-0.02% 🔽)
JS (gzip) 122.36 KB (-0.02% 🔽)
JS (brotli) 101.41 KB (+0.06% 🔺)
JS import Div (tree shaking) 1.47 KB (0%)
CSS 342.2 KB (0%)
CSS (gzip) 49.32 KB (0%)
CSS (brotli) 39.95 KB (0%)

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 2, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

e2e tests

Playwright Report

@codecov Codecov
Copy link

codecov bot commented Nov 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.17%. Comparing base (77eeaa0) to head (b661694).
Report is 13 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #7882   +/-   ##
=======================================
  Coverage   95.17%   95.17%           
=======================================
  Files         376      376           
  Lines       11041    11034    -7     
  Branches     3664     3664           
=======================================
- Hits        10508    10502    -6     
+ Misses        533      532    -1
Flag Coverage Δ
unittests 95.17% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 2, 2024

👀 Docs deployed

Commit b661694

andrey-medvedev-vk
andrey-medvedev-vk reviewed Nov 2, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Классно! 👍

packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx Show resolved Hide resolved
andrey-medvedev-vk
andrey-medvedev-vk approved these changes Nov 2, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

packages/vkui/src/components/HorizontalScroll/HorizontalScroll.tsx Show resolved Hide resolved
@EldarMuhamethanov EldarMuhamethanov merged commit f198947 into master Nov 5, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/7774/fix-arrow-scroll-by-mouse branch November 5, 2024 09:44
@EldarMuhamethanov EldarMuhamethanov added the v6 Автоматизация: PR продублируется в ветку v6 label Nov 5, 2024
EldarMuhamethanov added a commit that referenced this pull request Nov 5, 2024
@EldarMuhamethanov
fix(HorizontalScroll): fix scroll when mouse over arrow (#7882)
046d49b 
(cherry picked from commit f198947)
EldarMuhamethanov added a commit that referenced this pull request Nov 5, 2024
@EldarMuhamethanov
fix(HorizontalScroll): fix scroll when mouse over arrow (#7882)
3e7dcff 
(cherry picked from commit f198947)
This was referenced Nov 5, 2024
Merged
Merged
EldarMuhamethanov added a commit that referenced this pull request Nov 5, 2024
@EldarMuhamethanov
fix(HorizontalScroll): fix scroll when mouse over arrow (#7882) (#7897)
cb2aedc 
(cherry picked from commit f198947)
EldarMuhamethanov added a commit that referenced this pull request Nov 5, 2024
@EldarMuhamethanov
patch: pr7882 in v6 (#7898)
b7b5b48 
* fix(HorizontalScroll): fix scroll when mouse over arrow (#7882)

(cherry picked from commit f198947)

* test(DateRangeInput): fix test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

@inomdzhon inomdzhon inomdzhon approved these changes

Assignees
No one assigned
Labels
v6 Автоматизация: PR продублируется в ветку v6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: На стрелке в HorizontalScroll не работает прокрутка колесом
3 participants
@EldarMuhamethanov @inomdzhon @andrey-medvedev-vk