Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Spacing): add css variables support #7955

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

BlackySoul
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Документация фичи
  • Release notes

Описание

Иногда необходима возможность передать в кач-ве size просто css-переменную - для это даем возможность пробросить строку, которая начинается с --

Release notes

Улучшения

  • Spacing: добавлена возможность передать css-переменную в size
  • Separator: добавлена возможность передать css-переменную в size

@BlackySoul BlackySoul added this to the v7.0.0-beta.2 milestone Nov 18, 2024
@BlackySoul BlackySoul self-assigned this Nov 18, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner November 18, 2024 13:25
Copy link
Contributor

github-actions bot commented Nov 18, 2024

size-limit report 📦

Path Size
JS 385.63 KB (+0.03% 🔺)
JS (gzip) 116.96 KB (+0.04% 🔺)
JS (brotli) 96.18 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 334.8 KB (0%)
CSS (gzip) 42.35 KB (0%)
CSS (brotli) 33.43 KB (0%)

Copy link
Contributor

github-actions bot commented Nov 18, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 18, 2024

👀 Docs deployed

Commit 125e483

inomdzhon
inomdzhon previously approved these changes Nov 21, 2024
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

- style={{
-   ...spacingSizeStyle,
-   ...style,
- }}

+ style={spacingSizeStyle ? {
+   ...spacingSizeStyle,
+   ...style,
+ } : style}

типа когда spacingSizeStyle === undefined, то можно избегать лишнего спрединга и чуть-чуть сэкономить на рендере

Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@BlackySoul BlackySoul merged commit 74a656b into master Nov 21, 2024
25 of 26 checks passed
@BlackySoul BlackySoul deleted the blackysoul/spacing_vars_support branch November 21, 2024 18:14
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.2 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.2, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants