Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(HorizontalCell): add textAlign + noPadding + fixes #7980

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

BlackySoul
Copy link
Contributor

@BlackySoul BlackySoul commented Nov 22, 2024

  • e2e-тесты
  • Документация фичи
  • Release notes

Изменения

  • добавляем textAlign, потому что в случае задания кастомной ширины может потребоваться изменить выравнивание текста
  • добавляем noPadding, для удаления крайних элементов, чтобы можно было создавать обертку со своими отступами или вообще без них
  • при кастомном размере задаем ширину строго, чтобы соответствовать указанным параметрам
  • исправила размер ячейки, если она является единственной ячейкой в списке

Release notes

Улучшения

  • HorizontalCell:
    • добавлено свойство textAlign для выравнивания типографических элементов
    • добавлено свойство noPadding, отключающее отступы у крайних элементов

@BlackySoul BlackySoul self-assigned this Nov 22, 2024
@BlackySoul BlackySoul requested a review from a team as a code owner November 22, 2024 15:38
@BlackySoul BlackySoul added this to the v7.0.0-beta.2 milestone Nov 22, 2024
Copy link
Contributor

github-actions bot commented Nov 22, 2024

size-limit report 📦

Path Size
JS 385.95 KB (+0.08% 🔺)
JS (gzip) 116.97 KB (+0.07% 🔺)
JS (brotli) 96.29 KB (+0.03% 🔺)
JS import Div (tree shaking) 1.46 KB (0%)
CSS 334.98 KB (+0.1% 🔺)
CSS (gzip) 42.41 KB (+0.14% 🔺)
CSS (brotli) 33.42 KB (-0.01% 🔽)

Copy link

codesandbox-ci bot commented Nov 22, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link
Contributor

github-actions bot commented Nov 22, 2024

e2e tests

Playwright Report

Copy link
Contributor

github-actions bot commented Nov 22, 2024

👀 Docs deployed

Commit 8431a79

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.36%. Comparing base (4d68ba0) to head (8431a79).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7980   +/-   ##
=======================================
  Coverage   95.36%   95.36%           
=======================================
  Files         380      380           
  Lines       11321    11327    +6     
  Branches     3769     3774    +5     
=======================================
+ Hits        10796    10802    +6     
  Misses        525      525           
Flag Coverage Δ
unittests 95.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@BlackySoul BlackySoul force-pushed the blackysoul/horizontal_scroll_add_textAlign branch from 19c4c82 to dedb753 Compare November 25, 2024 05:37
@BlackySoul BlackySoul force-pushed the blackysoul/horizontal_scroll_add_textAlign branch from 476e1c4 to 8431a79 Compare November 25, 2024 09:44
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@BlackySoul BlackySoul merged commit 18d9508 into master Nov 25, 2024
28 checks passed
@BlackySoul BlackySoul deleted the blackysoul/horizontal_scroll_add_textAlign branch November 25, 2024 16:02
@vkcom-publisher
Copy link
Contributor

v7.0.0-beta.2 🎉

@inomdzhon inomdzhon modified the milestones: v7.0.0-beta.2, v7.0.0 Dec 2, 2024
@vkcom-publisher
Copy link
Contributor

v7.0.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants