test(todo): mv getFake*Event to *EventMock #8035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
andrey-medvedev-vk
approved these changes
Dec 3, 2024
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
e2e tests |
👀 Docs deployed
Commit 483c6da |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8035 +/- ##
=======================================
Coverage 95.47% 95.47%
=======================================
Files 393 393
Lines 11188 11188
Branches 3708 3708
=======================================
Hits 10682 10682
Misses 506 506
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
vkcom-publisher
added
pr-needs-work
SevereCloud
approved these changes
Dec 11, 2024
BlackySoul
pushed a commit
that referenced
this pull request
Dec 16, 2024
Зарезолвил TODO в тесте `useBottomSheet()`, который оставлял в #6759 Упростил `getFakeTouchEvent` и `getFakeMouseEvent` до функций, которые возвращают объект. Заметил, что если вторым аргументом в `fireEvent` из `testing-library/react` передавать объект события, то он работает не корректно – лучше передавать сразу опции, которые принимают те или иные события.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Зарезолвил TODO в тесте
useBottomSheet(), который оставлял в #6759Упростил
getFakeTouchEventиgetFakeMouseEventдо функций, которые возвращают объект.Заметил, что если вторым аргументом в
fireEventизtesting-library/reactпередавать объект события, то он работает не корректно – лучше передавать сразу опции, которые принимают те или иные события.Release notes