Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Calendar): fix view in rtl #8068

Merged
merged 4 commits into from
Dec 13, 2024
Merged

feat(Calendar): fix view in rtl #8068

merged 4 commits into from
Dec 13, 2024

Conversation

EldarMuhamethanov
Copy link
Contributor

  • Unit-тесты
  • e2e-тесты
  • Release notes

Описание

Сейчас компоненты Calendar и CalendarRange не совсем корректно отображаются в rtl, нужно доработать

Изменения

  • Поправил отображение кнопок перехода к следующему/предыдущему слайду в компоненте CalendarHeader в rtl
  • Поправил отображение индикатора текущего дня в CalendarDay

Release notes

Улучшения

  • Calendar: Доработано отображение компонента в rtl режиме
  • CalendarRange: Доработано отображение компонента в rtl режиме

@EldarMuhamethanov EldarMuhamethanov added this to the v7.1.0 milestone Dec 12, 2024
@EldarMuhamethanov EldarMuhamethanov self-assigned this Dec 12, 2024
@EldarMuhamethanov EldarMuhamethanov requested a review from a team as a code owner December 12, 2024 09:35
@github-actions GitHub Actions
Copy link
Contributor

size-limit report 📦

Path Size
JS 388.86 KB (+0.13% 🔺)
JS (gzip) 117.98 KB (+0.13% 🔺)
JS (brotli) 97.18 KB (+0.15% 🔺)
JS import Div (tree shaking) 1.56 KB (0%)
CSS 341.09 KB (+0.04% 🔺)
CSS (gzip) 42.25 KB (+0.03% 🔺)
CSS (brotli) 33.63 KB (+0.09% 🔺)

@codesandbox-ci CodeSandbox CI
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@github-actions GitHub Actions
Copy link
Contributor

e2e tests

⚠️ Some screenshots were failed. See Playwright Report.

Playwright Report

@codecov Codecov
Copy link

codecov bot commented Dec 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.60%. Comparing base (6f6e984) to head (87ba27f).
Report is 2 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #8068   +/-   ##
=======================================
  Coverage   95.59%   95.60%           
=======================================
  Files         397      398    +1     
  Lines       11297    11321   +24     
  Branches     3723     3728    +5     
=======================================
+ Hits        10799    10823   +24     
  Misses        498      498
Flag Coverage Δ
unittests 95.60% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

👀 Docs deployed

Commit 87ba27f

andrey-medvedev-vk
andrey-medvedev-vk approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@andrey-medvedev-vk andrey-medvedev-vk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💠

inomdzhon
inomdzhon approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@inomdzhon inomdzhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💅 👍

packages/vkui/src/components/CalendarDay/CalendarDay.module.css Show resolved Hide resolved
@EldarMuhamethanov EldarMuhamethanov merged commit ead8d91 into master Dec 13, 2024
28 checks passed
@EldarMuhamethanov EldarMuhamethanov deleted the e.muhamethanov/fix-calendar-rtl branch December 13, 2024 15:23
BlackySoul pushed a commit that referenced this pull request Dec 16, 2024
@EldarMuhamethanov @BlackySoul
feat(Calendar): fix view in rtl (#8068)
c81aa61 
* fix(Calendar): fix view in rtl

* fix(Calendar): make rtl with context

* test: add screenshot test to rtl
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inomdzhon inomdzhon inomdzhon approved these changes

@andrey-medvedev-vk andrey-medvedev-vk andrey-medvedev-vk approved these changes

Assignees

@EldarMuhamethanov EldarMuhamethanov

Labels
cmp:calendar cmp:calendar-range type:feature
Projects
VKUI
Archived in project
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@EldarMuhamethanov @inomdzhon @andrey-medvedev-vk