Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce stutter in warning messages #397

Closed
quasilyte opened this issue Apr 11, 2020 · 0 comments · Fixed by #403
Closed

Reduce stutter in warning messages #397

quasilyte opened this issue Apr 11, 2020 · 0 comments · Fixed by #403
Milestone
v0.1.0

Comments

@quasilyte
Copy link
Contributor

Code Example

function f() {
  $v = 10;
}

Actual Behavior

UNUSED  unused: Unused variable v (use $_ to ignore this inspection) at example.php:4
  $v = 10;
  ^^

Expected Behavior

Something that doesn't say "unused" 3 times. 1 time (or maybe 2) is enough for most people. 😅
@quasilyte quasilyte added this to the v0.1.0 milestone Apr 12, 2020
quasilyte added a commit that referenced this issue Apr 12, 2020
@quasilyte
linter: reduce stutter in unused warnings
12b58bb 
Before:
	UNUSED  unused: Unused variable v

1. Replace UNUSED with INFO in non-LSP mode:
	INFO    unused: Unused variable v

2. Re-word message:
	INFO    unused: Vairable v is unused

Fixes #397

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
This was referenced Apr 12, 2020
Merged
Closed
quasilyte added a commit that referenced this issue Apr 12, 2020
@quasilyte
linter: reduce stutter in unused warnings
e873a13 
Before:
	UNUSED  unused: Unused variable v

1. Replace UNUSED with INFO in non-LSP mode:
	INFO    unused: Unused variable v

2. Re-word message:
	INFO    unused: Vairable v is unused

Fixes #397

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
quasilyte added a commit that referenced this issue Apr 12, 2020
@quasilyte
linter: reduce stutter in unused warnings (#403)
55982a2 
Before:
	UNUSED  unused: Unused variable v

1. Replace UNUSED with INFO in non-LSP mode:
	INFO    unused: Unused variable v

2. Re-word message:
	INFO    unused: Vairable v is unused

Fixes #397

Signed-off-by: Iskander Sharipov <quasilyte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.1.0
Development

Successfully merging a pull request may close this issue.

linter: reduce stutter in unused warnings VKCOM/noverify
1 participant
@quasilyte