Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Тема проекта Pulse #267

Merged
merged 3 commits into from
Nov 30, 2022
Merged

Conversation

petermihailov
Copy link

Перед отправкой этого реквеста на ревью убедитесь, что:

  • в вашей ветке работает сборка (npm run build:local),
  • в вашей ветке проходят тесты (npm test),
  • в вашей ветке проходит линтер (npm run lint), некоторые ошибки можно автоматически поправить с помощью npm run lint:fix,
  • покрытие тестов не ниже минимального значения,
  • если вы вносите изменения в задокументированные части библиотеки,
    ваш pull request содержит обновления документации,
  • если вы вносите изменения в сами токены, вы
    согласовали их с дизайнерами.

Подробнее о внесении изменений в репозиторий токенов

src/interfaces/themes/pulse/index.ts Show resolved Hide resolved
src/interfaces/themes/pulse/index.ts Outdated Show resolved Hide resolved
src/themeDescriptions/themes/pulse/index.ts Outdated Show resolved Hide resolved
src/themeDescriptions/themes/pulse/index.ts Outdated Show resolved Hide resolved
src/themeDescriptions/themes/pulse/index.ts Outdated Show resolved Hide resolved
src/themeDescriptions/themes/pulse/index.ts Outdated Show resolved Hide resolved
src/themeDescriptions/themes/pulse/index.ts Outdated Show resolved Hide resolved
@petermihailov petermihailov force-pushed the vkui-pulse-theme branch 2 times, most recently from 41b528e to 5296c90 Compare November 17, 2022 09:58
@petermihailov petermihailov requested a review from 8coon November 17, 2022 10:01
@8coon 8coon added the minor label Nov 28, 2022
@8coon 8coon changed the base branch from master to 4.25.0 November 30, 2022 14:14
@8coon 8coon merged commit f1f9f82 into VKCOM:4.25.0 Nov 30, 2022
@8coon 8coon mentioned this pull request Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants