Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Docker関連ファイルの削除とTyposのスクリプトの追加 #2239
fix: Docker関連ファイルの削除とTyposのスクリプトの追加 #2239
Changes from 23 commits
17502c8
3539b04
a70e64e
35321fe
c1c44a2
0645e30
4c2b448
8adb48b
6456c06
cc565e8
a5c42e3
b2b4ceb
2d620bd
2aee482
8387004
b9a9768
6a34889
ee91136
e9a4b24
6d8483a
1472a72
3a45518
4e7c3ae
a538cbd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(判断メモです!)
こちらのファイルは他のファイルに比べるとコメントが結構多めで、一部冗長な箇所もあるなと感じました!
が、問題なさそうと思いました!
ここはビルドでしか使われなく、おそらく滅多に変更されることはないと思われます。
よく変更される箇所でしたらより洗練する方がいいかもしれませんが、ここはあまり変更されない場所なので、丁寧にコメントされているのはOKだと思います!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(ただのコメントです)
ここ、たぶんパイプ経由で保存している感じですよね。
Node.js的にはもっとスマートの解決策があって、responseからバイナリーを得て、fs.writeFileなどで普通にファイル出力する方が一般的かもです。
もし次書く機会あればぜひ・・・!
This file was deleted.