[Rust] yukarin_s_forward を実装した #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re/implements-yukarin_s_forward
Hiroshiba
approved these changes
Jun 10, 2022
Hiroshiba
reviewed
Jun 10, 2022
qwerty2501
reviewed
Jun 11, 2022
qwerty2501
reviewed
Jun 11, 2022
43 tasks
qwerty2501
pushed a commit
to qwerty2501/voicevox_core
that referenced
this pull request
Jul 23, 2022
* add yukarin_s_forward implementation * use replace method * use std::slice::from_raw_parts_mut * change argument type of Internal::yukarin_s_forward * fix to use proper speaker_id * use assert_eq
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
yukarin_s_forward を実装し、テストも書きました。とりあえず動きます。
onnxruntime-rsがndarrayと蜜結合した形で記述されていたため、素直にndarrayクレートを導入しました。ndarrayを使った経験がないため、もっと適切な書き方があるかどうかわからなかったのですが、とりあえず提出しました。関連 Issue
#128