Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rust]音が途切れてしまうのを避けるworkaround処理を追加した #161

Merged
merged 3 commits into from
Jun 26, 2022
Merged

[Rust]音が途切れてしまうのを避けるworkaround処理を追加した #161

merged 3 commits into from
Jun 26, 2022

Conversation

qwerty2501
Copy link
Contributor

@qwerty2501 qwerty2501 commented Jun 20, 2022 •
edited
Loading

内容

C++実装にあった音が途切れてしまうのを避けるworkaround実装です

関連 Issue

refs #128

その他

オリジナルの実装は このあたり になります

@qwerty2501
Copy link
Contributor Author

実装した関数のテストコードがまだなのと、実際に生成した音声が途切れていないか確認できていないためDraft

@PickledChair PickledChair marked this pull request as ready for review June 20, 2022 17:42
@PickledChair PickledChair marked this pull request as draft June 20, 2022 17:44
Hiroshiba
Hiroshiba approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

実際にちゃんと稼働してるかの確認ちょっと大変そうなので、いったんエイヤでマージしちゃって良い気がします…！

確認するなら、「ああ」あたりのテキストで生成した音声を比較するとわかる…かも…？

crates/voicevox_core/src/internal.rs Outdated Show resolved Hide resolved
crates/voicevox_core/src/internal.rs Outdated Show resolved Hide resolved
@Hiroshiba
Copy link
Member

あ、元の実装を再現してくださってたのに確認せずとやかく言っちゃいました…🙇‍♂️

@PickledChair PickledChair mentioned this pull request Jun 20, 2022
Closed
43 tasks
@qwerty2501 qwerty2501 marked this pull request as ready for review June 21, 2022 10:37
@qwerty2501
Copy link
Contributor Author

@Hiroshiba 指摘があったところについて修正しました
テストと動作確認についてですが、よくよく考えると将来的に消える可能性のあるworkaround codeに対してテストコードをつくるコストはあまりかけたくないという結論になったのと、
動作確認についても現状rust製のdllでexampleが動くようになっていないのもありこのままレビューという形にしたいと思います。

Hiroshiba
Hiroshiba approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！！

個人的には一旦マージで問題ないと感じています！

PickledChair
PickledChair approved these changes Jun 26, 2022
View reviewed changes
Copy link
Member

@PickledChair PickledChair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM！ マージします……！

@PickledChair PickledChair merged commit 2dabb4c into VOICEVOX:rust Jun 26, 2022
qwerty2501 added a commit to qwerty2501/voicevox_core that referenced this pull request Jul 23, 2022
@qwerty2501
[Rust]音が途切れてしまうのを避けるworkaround処理を追加した (VOICEVOX#161)
da1d48d 
* 音が途切れてしまうのを避けるworkaround処理を追加した

* padding_phonemeを一まとまりにするように修正した

* paddingのsize変数名をpadding_sizeに統一した
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hiroshiba Hiroshiba Hiroshiba approved these changes

@PickledChair PickledChair PickledChair approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qwerty2501 @Hiroshiba @PickledChair