追加: 貢献者ガイドブラッシュアップ #1215
Merged
追加: 貢献者ガイドブラッシュアップ #1215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
approved these changes
May 9, 2024
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
Co-authored-by: Hiroshiba <hihokaruta@gmail.com>
|
@Hiroshiba |
Hiroshiba
reviewed
May 15, 2024
|
@Hiroshiba |
Hiroshiba
approved these changes
May 29, 2024
There was a problem hiding this comment.
LGTMです！！！
非常に良いガイドラインだと思います！ありがとうございます！！！
いくつか方針等についてメモがてらコメントです！
貢献者ガイドのリリース
ぜひリリース（ちゃんと公開＆案内）したいです！！
あとはREADME側で重複してる部分を消して、工事中案内文を消して、CONTRIBUTOR.mdへのリンクを案内すればOKという認識です！
（重複部分はAPIユーザー向けのものもあるはずなので、そこはそのままが良さそう。具体的にはUTF8のとこ。）
エディタ側のガイドラインとの兼ね合い
@nmori さんがエディタ側で貢献者ガイドラインを書いてくださっています。
エディタガイドラインはGithubとGitの使い方に比重が置かれている感じです。
エディタは特に初学者の方（特にGithub初学の方）が多めだと思うので、特色が違う形で良いのかなと思ってます！
とりあえずご共有まで 🙏
tarepan
force-pushed
the
refactor/brushup_contrib
branch
from
089aec2
to
b410fac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要: 大幅ブラッシュアップ版の貢献者ガイドを追加
React の
How to Contributeを参考にしてCONTRIBUTING.mdを大幅ブラッシュアップした。関連 Issue
ref #1130 (comment)