Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

廃止: CI pip 環境更新を削除 #1288

Merged
merged 1 commit into from
May 24, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 20, 2024

内容

CI での Python 依存パッケージインストールにおいて、pip 環境の更新(python -m pip install --upgrade pip setuptools wheel)をおこなうケースが 1 箇所だけ存在する。
CI は固定環境での安定したテスト・ビルドが目的であるため、pip / setuptools / wheel であってもバージョン指定無しにアップグレードを掛けるべきではない。

このような背景から、CI pip 環境更新コマンドを削除して環境更新を廃止することを提案します。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 20, 2024 12:13
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 20, 2024 12:13
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

昔はこのあたりのツールがrequirements.txtに含まれてなかったのの名残かもですね。
(と思ったけど今もpipやwheelは含まれてなさそう。だけど別に問題なさそう。)

@Hiroshiba Hiroshiba merged commit 6d9eed0 into VOICEVOX:master May 24, 2024
4 checks passed
@tarepan tarepan deleted the remove/pip_update branch May 24, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants