Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: テスト指摘箇所を改善 #1315

Merged
merged 4 commits into from
May 28, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 24, 2024

内容

pytest 移行に伴い review で発見された問題点を改善するリファクタリングを提案します。

関連 Issue

上記参照

@tarepan tarepan requested a review from a team as a code owner May 24, 2024 03:55
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 24, 2024 03:56
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

統一感が増したと思います!

@Hiroshiba Hiroshiba merged commit fc73575 into VOICEVOX:master May 28, 2024
4 checks passed
@tarepan tarepan deleted the refactor/test_review branch May 29, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants