Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: 設定 UI テンプレートファイルのネストを削除 #1337

Merged
merged 1 commit into from
May 28, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 27, 2024

内容

ui_template/ui.html のネストを削除してリファクタリングすることを提案します。

変更後、以下のチェックをおこないました:

  • pyinstaller ビルド → 成功
  • ./dist/run/run 実行 → 成功
  • GET /setting で設定ページアクセス → 成功

関連 Issue

ref #1251 (review)

@tarepan tarepan requested a review from a team as a code owner May 27, 2024 08:23
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 27, 2024 08:23
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

確認もありがとうございます!

@Hiroshiba Hiroshiba merged commit d86007e into VOICEVOX:master May 28, 2024
4 checks passed
@tarepan tarepan deleted the refactor/ui_template_nest branch May 29, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants