Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: speaker_inforesources/character_info へ移動 #1353

Merged
merged 6 commits into from
Jun 2, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 29, 2024

内容

speaker_info ディレクトリを resources/character_info へ移動するリファクタリングを提案します。

以下が動作確認済みです:

  • ビルド
  • ./dist/run/run --enable_mock エンジン実行
  • GET /speakers リクエスト
  • GET /speaker_info?speaker_uuid=xxx リクエスト

関連 Issue

resolve #1339

@tarepan tarepan requested a review from a team as a code owner May 29, 2024 11:17
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 29, 2024 11:17
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

ビルドが通るか楽しみですね!

run.py Outdated Show resolved Hide resolved
voicevox_engine/app/routers/speaker.py Outdated Show resolved Hide resolved
@Hiroshiba Hiroshiba merged commit b10fb4c into VOICEVOX:master Jun 2, 2024
4 checks passed
@tarepan tarepan deleted the refactor/resources_speaker branch June 2, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: speaker_info ディレクトリを resources/ へ移動
2 participants