Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: テストユーティリティのテストを追加 #1355

Merged
merged 2 commits into from
Jun 2, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented May 29, 2024

内容

テストユーティリティのテストを追加するリファクタリングを提案します。

関連 Issue

無し

@tarepan tarepan requested a review from a team as a code owner May 29, 2024 16:50
@tarepan tarepan requested review from Hiroshiba and removed request for a team May 29, 2024 16:50
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

意外とテスト用のユーティリティもvoicevox_engine側にあっても良いかもですね。
(今のところ、なんとなくそうでも良いんだな〜と思っただけです)

@Hiroshiba Hiroshiba merged commit de4c24a into VOICEVOX:master Jun 2, 2024
4 checks passed
@tarepan tarepan deleted the refactor/util_test branch June 2, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants