整理: verify_mutability() で mutability チェックを置き換え
#1363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hiroshiba
reviewed
Jun 2, 2024
Hiroshiba
reviewed
Jun 2, 2024
|
@Hiroshiba |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
概要:
verify_mutability()で mutability チェックを置き換えてリファクタリング現在の API mutability チェックはグローバルオブジェクトを利用している。グローバルオブジェクトは影響範囲の理解にコストがかかり、また多重操作によるバグの温床になりやすい。
dependency 関数を明示的に router 引数で渡せば、限局された範囲に静的な関数が渡るため見通しを改善できる。
このような背景から、
verify_mutability()で mutability チェックを置き換えるリファクタリングを提案します。関連 Issue
無し