整理: ライブラリの HTTPException を独自エラーで置き換え
#1371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarepan
requested review from
Hiroshiba and
sevenc-nanashi
and removed request for
a team
|
あっ すみません、ちょっと自信なさ気なコンフリクトが発生してしまったので解消をお願いできると･･･ 🙇 |
|
@Hiroshiba |
Hiroshiba
reviewed
Jun 15, 2024
Comment on lines
+65
to
+74
| except LibraryNotFoundError as e: | ||
| raise HTTPException(status_code=404, detail=str(e)) | ||
| except LibraryFormatInvalidError as e: | ||
| raise HTTPException(status_code=422, detail=str(e)) | ||
| except LibraryUnsupportedError as e: | ||
| raise HTTPException(status_code=422, detail=str(e)) | ||
| except LibraryOperationUnauthorizedError as e: | ||
| raise HTTPException(status_code=403, detail=str(e)) | ||
| except LibraryInternalError as e: | ||
| raise HTTPException(status_code=500, detail=str(e)) |
There was a problem hiding this comment.
このエラー変換は２箇所にあって、片方変えたときにもう片方変え忘れちゃうかもですね。
何かしらのエラー変換関数を作ってあげると良いかも･･･？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
ライブラリの
HTTPExceptionを独自エラーで置き換えるリファクタリングを提案します。また、他 PR にてエラーメッセージのテストは過剰（E2E のスナップショットが適切）との指摘があったため、ライブラリテストでもメッセージのテストを削除しました。
関連 Issue
無し