Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

整理: _PartOfSpeechDetaildataclass へ変更 #1395

Merged
merged 4 commits into from
Jun 19, 2024

Conversation

tarepan
Copy link
Contributor

@tarepan tarepan commented Jun 12, 2024

内容

#1405 に基づき _PartOfSpeechDetaildataclass へ変更するリファクタリングを提案します。

関連 Issue

part of #1405

@tarepan tarepan requested a review from a team as a code owner June 12, 2024 01:49
@tarepan tarepan requested review from Hiroshiba and removed request for a team June 12, 2024 01:49
@tarepan tarepan marked this pull request as draft June 18, 2024 10:34
@tarepan tarepan marked this pull request as ready for review June 19, 2024 06:52
@tarepan
Copy link
Contributor Author

tarepan commented Jun 19, 2024

#1405 の Go 判断に基づき draft を解除しました。レビューよろしくお願いします。

@tarepan tarepan changed the title 整理: PartOfSpeechDetaildataclass へ変更 整理: _PartOfSpeechDetaildataclass へ変更 Jun 19, 2024
Copy link
Member

@Hiroshiba Hiroshiba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Hiroshiba Hiroshiba merged commit 25b367a into VOICEVOX:master Jun 19, 2024
4 checks passed
@tarepan tarepan deleted the refactor/pos_simple branch June 19, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants