Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
内容
flake8-bugbear 22.10.25 以降で追加されたチェックルール (B027: Empty method in abstract base class with no abstract decorator) に違反するコードを修正します.
この PR では, B027 を 無視 します. 指摘のあった
initialize_speaker_synthesis()
は, docstring にもある通り,のが仕様です. よって, これは抽象メソッドではなく,
@abstractmethod
デコレータを付与する必要はありません (実際, 付与するとテストが落ちます).関連 Issue
この指摘事項は #535 で依存関係 (flake8-bugbear) がアップグレードされた際に検出されました. #535 のマージにはこの PR のマージが必要です.
当該の Run: https://github.com/VOICEVOX/voicevox_engine/actions/runs/3776794325/jobs/6420846964
スクリーンショット・動画など
その他