Rapid-cue-switch crash bug mitigation #201
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sets previous frame cue tip position to current position on local turn start. Prevents the ball from being launched halfway across the map if the player manages to arm the cue with the cue tip already touching the cue ball.
Checks contents of Sqrt calculations to ensure they are >= 0. Prevents a VRchat crash in the event that a player manages to arm the cue with the tip far enough inside the ball to create an invalid state.
|
|
xenimax
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mitigation for #200
Prevent a crash when the player manages to arm the cue before their turn is up with the tip inside the cue ball, resulting in invalid location data. Ensures contents of relevant Sqrt functions is >= 0, and that stale location data isn't carried over on the first frame of the turn.