Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis script update #301

Closed
jcoupey opened this issue Feb 10, 2020 · 1 comment · Fixed by #302
Closed

Travis script update #301

jcoupey opened this issue Feb 10, 2020 · 1 comment · Fixed by #302
Labels
compilation
Milestone
v1.6.0

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Feb 10, 2020 •
edited
Loading

The Travis script needs an update to remove a couple of TODOs.

Some of the CI builds triggered by merge commits on master or push on PR branch seem to stop early due to this check. It's supposed to not run build at all if no source file has been modified, but for some reason it calls travis_terminate 0 even if some of the *.cpp and *.h files have been changed.
@jcoupey jcoupey added this to the v1.6.0 milestone Feb 10, 2020
@jcoupey jcoupey mentioned this issue Feb 10, 2020
Merged
4 tasks
@jcoupey
Copy link
Collaborator Author

jcoupey commented Feb 10, 2020

Also sometimes running make fails in the Travis script but the build is OK because this line runs travis_terminate 0.

@jcoupey jcoupey changed the title Travis does not always run make Travis script update Feb 10, 2020
jcoupey added a commit that referenced this issue Feb 10, 2020
@jcoupey
Simplify Travis script. #301
cc25bc4
jcoupey added a commit that referenced this issue Feb 18, 2020
@jcoupey
Simplify Travis script. #301
620a0b5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compilation
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging a pull request may close this issue.

Fix/travis builds VROOM-Project/vroom
1 participant
@jcoupey