Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to C++17 #311

Closed
jcoupey opened this issue Mar 12, 2020 · 1 comment · Fixed by #322
Closed

Switch to C++17 #311

jcoupey opened this issue Mar 12, 2020 · 1 comment · Fixed by #322

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Mar 12, 2020

Upgrading to C++17 would probably not be a huge change for the codebase. The only drawback I can see would be to drop support for some of the older compilers but we can definitely live with that.

On the other hand, some of the new language features like std::optional could help us reduce dependencies requirements. The impact on building Docker images or launching CI builds is probably worth the trouble.

@jcoupey
Copy link
Collaborator Author

jcoupey commented Apr 17, 2020

One last problem is that when building against libosrm the -std=c++14 flag is retrieved along with added flags when running:

 pkg-config --cflags libosrm

So we end up with two conflicting values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant