Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong index values without custom matrix #683

Closed
jcoupey opened this issue Mar 3, 2022 · 1 comment
Closed

Wrong index values without custom matrix #683

jcoupey opened this issue Mar 3, 2022 · 1 comment

Comments

@jcoupey
Copy link
Collaborator

jcoupey commented Mar 3, 2022

When providing custom matrices, users have to describe the matching between locations in the instance and matrices columns/lines. This happens using start_index and end_index keys for vehicles and location_index for tasks.

Those keys do not make sense when no custom matrix is provided. In that case, location index values are decided on the fly depending of the order in which locations are added.

The problem is that it's still possible to pass *_index keys without a matrix, and then we'll later rely on those index values to retrieve durations/costs internally. Generally in a way that is inconsistent with how the actual matrices have been defined, leading to weird optimization choices.

In order to fix this, we should error whenever a custom index has been used but no matrix has been manually set.

@jcoupey jcoupey added this to the v1.12.0 milestone Mar 3, 2022
PattyDePuh added a commit to PattyDePuh/vroom that referenced this issue Apr 27, 2022
@jcoupey
Copy link
Collaborator Author

jcoupey commented Apr 27, 2022

Landed in #698.

@jcoupey jcoupey closed this as completed Apr 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant