Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add location_index and description field to output, add shared target to makefile #627

Merged
merged 4 commits into from
Jan 6, 2022

Conversation

krashish8
Copy link
Contributor

@krashish8 krashish8 commented Dec 17, 2021

Issue

Fixes #403, #617, #625

Tasks

@krashish8
Copy link
Contributor Author

It's funny how after adding the description and location_index keys, I realized that these changes only affect the end JSON-API users. The users that are using libvroom in C++ are not affected, and they could get this done even earlier. So, in truth, this change won't make any difference to us, but might be a bit helpful to the community! :-)

@jcoupey jcoupey added this to the v1.12.0 milestone Dec 29, 2021
@jcoupey jcoupey merged commit 9d59989 into VROOM-Project:master Jan 6, 2022
@jcoupey
Copy link
Collaborator

jcoupey commented Jan 6, 2022

Thanks for the PR!

this change won't make any difference to us, but might be a bit helpful to the community!

You're definitely earning some open-source karma points here. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add 'description' to unassigned
2 participants