Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include response in exception for invalid routing response #765

Merged

Conversation

SimonBradley1993
Copy link
Contributor

@SimonBradley1993 SimonBradley1993 commented Aug 25, 2022

Issue

Issue : #764

This includes the response in the Routing Exception to allow clients of the application to identify what the issue is.

Tasks

  • Update exception message
  • Update CHANGELOG.md (remove if irrelevant)
  • review

@jcoupey jcoupey added this to the v1.13.0 milestone Aug 29, 2022
@jcoupey
Copy link
Collaborator

jcoupey commented Aug 29, 2022

This makes sense, thanks for the PR!

While looking at the code I was surprised the same change was not necessary in ssl_send_then_receive and it turns out we're missing a couple throw there. Could you add them in this PR to fix #770 along the way?

Please also add a changelog entry.

@SimonBradley1993
Copy link
Contributor Author

This makes sense, thanks for the PR!

While looking at the code I was surprised the same change was not necessary in ssl_send_then_receive and it turns out we're missing a couple throw there. Could you add them in this PR to fix #770 along the way?

Please also add a changelog entry.

Thanks for looking at this so quickly. I've made the changes you asked for.

Let me know if there's anything else needed for this 🙂

@jcoupey jcoupey merged commit 3a191ea into VROOM-Project:master Aug 30, 2022
@SimonBradley1993 SimonBradley1993 deleted the enhancement/IncludeResponse branch August 30, 2022 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants