-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auto Updating Support #41
Comments
Use the deb repository. See the README. |
The deb repository might be a good idea for Linux users. For Mac users we will have to figure something else out. It's not the best experience having to check the repo for updates or ask brew for updates. This could use some discussion. |
Homebrew can auto-update. Even in Debian, auto-updates do not happen automatically. You still have to type |
I think we can get something like that working. I need to investigate out it currently works in vscode |
Yes, there must be a proper interface for that feature, we need to check how to configure the same. I'll see if I can figure out something. |
In case anyone want's to do it with a simple bash-"script", that you can trigger as often as you like... wget -q -O /tmp/vscodium.deb $(wget -O- -q https://api.github.com/repos/VSCodium/vscodium/releases/latest | grep browser_download_url | cut -d '"' -f 4 | grep "amd64.deb") && sudo apt -f install /tmp/vscodium.deb && rm /tmp/vscodium.deb Note: This Only supports dpkg/apt and amd64... :-) |
Out of personal interesst I looked into the source of the updater-mechanism... It seems that the update mechanisms hits this URL. See the following folder for the concrete implementation of the updater-service. the abstract implementation contains the basic URL-schemantics for all platforms and the actual "update-checking" happens in the platform-specific implementations. I'd probably try to change the update-url in the gulp-build-process to localhost or similar and would see what gets requested and try to respond... |
Found some more resources when opened The https://vscode-update.azurewebsites.net/api/update/darwin/stable/VERSION If we can configure custom update URL & replicate above response format, things should probably work? |
I would guess so as well. I know that you can host static pages on github (??repo??.github.io or something...) Maye on each build push a file with the necessary information into the repo-root and host it directly from github itself? |
Yup, that should work. As far as I know build folder of VSCode repo should have most of the necessary scripts to make it work. Will investigate further. |
We can just host the one json directly in vscodium repo. |
@ganapativs @tynx thank you both for digging in. Yes-- this is perfect, we can easily host a JSON file that has the latest version with its hash and download link in the repo and update it at build time. When I have a few minutes I'll dig in, but PRs are welcome in the meantime. Again thank you all for digging in, as this is a piece of the vscodium puzzle that was really in need of solving 👍 |
Circling back to this today... I think the next steps are:
I'll start investigating |
Another step is that updates apparently won't work unless the app is signed. I'm not sure how to sign the app during Travis build so that is something I've got to figure out. |
Is it verified? Someone tried it? We don't sign VSCodium build as of now right? |
@ganapativs vscode uses electron's autoupdater functionality, and the electron docs here say the app needs to be signed for Mac OS. We don't currently sign the builds. Do you know how to do this in an safe automated way? |
@stripedpajamas Okay, I don't know much about signing desktop apps, but found this electron code signing resource, which might help. |
Also, not to be pedantic, but Windows users would surely also appreciate the ability, as they have had it for Standard vsc. |
Absolutely, @batjko. This is definitely something that should be near the top of the priority list as it is a big shortcoming of VSCodium as compared to VSC. |
Hello! |
Some more notes to keep the ball rolling and so I don't forget:
So might need to stand up a small update server to handle the details. |
Ok I made some progress on this over the past couple of days. Here is an update:
Testing everything out is not intuitive, so I will probably have to write up a Contributing Guide pretty soon that covers VSCodium, the update API, and the versions repo. I will try to test it out with an older version of VSCodium and see how it responds to the API. |
I was successfully auto-updated on my Mac using the new service 🎉 Testing steps:
I updated the project to include adding Notes on Linux: I don't know if anyone has had experience with autoupdates on Linux, but since the API returns the |
Good news -- I updated the version updater to support Windows and then tested auto updating on a Windows machine (x64, user install) -- it worked 🎉 Next step according to the project is to add two fields to the product.json file and then call it a day (wait for the next MS release). Actually will have to wait for two more MS releases -- the first will make VSCodium start checking for updates, the second will be a new version that VSCodium downloads + installs. |
Check for update return server error 404. Version: 1.35.0 (system setup) |
System setup updates are not supported. I'm not certain that they're supported by Microsoft either because it looked like the update code specified user or archive. |
Yes, they are supported. I also tried to install the user setup 1.35.0 for check the update of 1.35.1 and the message shown was that vscodium is already updated, it's normal? There even should be a "pop-up message" on bottom right side, like vscode, that alert me about an update? |
Is this even supported on Linux with VSCode? When they request you update the software, it navigates you to https://code.visualstudio.com to download a |
hi there - i need to update vscodium on mxlinux at the moment i am on mx-linux version 19.2 running vscodium: 1.47.3 want to update to the newest vscodium: 1.52.1 saw that we can go probably this way: is this an apropiate way: the folks there have got a three-step-solution a. add gpg-key of the repository b. add the repository c. update then install vscodium look forward to hear from you |
Hiya,
Not opening that. Instead of sharing mysterious SERP I just update VSCodium via my distribution's native package manager.
I don't know what that means, but I suggest you investigate the packaging https://github.com/VSCodium/vscodium#install-with-package-manager P.S. Sending mysterious links is off-putting. |
How does auto updating works here? how are we pushing the new update?
also anyone has idea about how to configure custom
update.channel
?The text was updated successfully, but these errors were encountered: