Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows version update #164

Merged
merged 8 commits into from
May 20, 2019

Conversation

stripedpajamas
Copy link
Member

This PR adds support in the update_version.sh script for Windows builds. It means that after deploying new Windows artifacts, the build will cobble together the necessary parts of a version JSON file and commit it to VSCodium/versions for use by the VSCodium/update-api

Changes made:

  • Abstract most of the update_version.sh logic into functions because Windows builds have to do everything twice (archive + user)
  • Have Windows builds use the node module checksum to compute the sums because shasum doesn't work and Get-FileHash has horrible output
  • Made the update commit to /versions instead of hardcoding VSCodium/versions. This makes it so that if you fork VSCodium/versions and add your own GITHUB_TOKEN env var to your fork of VSCodium/vscodium's Travis build, the build will update your own versions repo
  • Add shasums for dmg artifacts

cc #41

@stripedpajamas stripedpajamas merged commit 75a7941 into VSCodium:master May 20, 2019
@stripedpajamas stripedpajamas deleted the windows-version-update branch May 20, 2019 16:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant