Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add build/ and dist/ to the .gitignore file #641

Closed
bradleyharden opened this issue Apr 7, 2020 · 1 comment
Closed

Please add build/ and dist/ to the .gitignore file #641

bradleyharden opened this issue Apr 7, 2020 · 1 comment

Comments

@bradleyharden
Copy link
Contributor

In the container setup I created at work, VUnit is included as a submodule, and it is installed with python3 setup.py install inside the container. That creates build and dist directories inside the VUnit folder, which makes the submodule show untracked content. I include VUnit as a submodule in the repo, because it lets us keep track of which version of VUnit is used for the repo and decouples the version of VUnit from the container used for simulation.

I can get rid of build by running python3 setup.py clean --all after installation, but that still doesn't get rid of the dist folder.

For anyone else who has a similar problem but can't easily modify the submodule's .gitignore, you can add lines to the submodule info/exclude file inside the .git/modules/ folder.

@eine
Copy link
Collaborator

eine commented Apr 7, 2020

Note that, as an alternative to installing the package, you can add the location of the submodule to envvar PYTHONPATH. In certain contexts, this will allow you to use several versions of VUnit at the same time.

Anyway, I think it makes sense to update .gitignore.

eine added a commit to eine/vunit that referenced this issue Apr 7, 2020
@eine eine closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants