Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check_axi_stream non-blocking #483

Merged
merged 3 commits into from
Apr 24, 2019
Merged

Conversation

eschmidscs
Copy link
Contributor

This resolves #477

I reused the same function with an additional argument with default value for backward compatibility (compared to the current master).
I prefer that to a separate function, but let me know if you think otherwise.

Only the specific axi_stream stuff is updated. One could think of doing the same to the generic stream_slave, but I can't handle the consequences (would need to update the uart...).

Running all checks in verification_components seems to fail with questa due to some delta-cycle differences with GHDL... :-/ GHDL looks fine here.

@kraigher
Copy link
Collaborator

Did the tests fail in questa on master as well? Unfortunately we cannot run CI on the commercial simulators like we do with GHDL.

@eschmidscs
Copy link
Contributor Author

The test already there, yes. It is the "tb_avalon_master.wait until idle" test in probably all configurations. I did not look into it - it fails with questa but is ok with ghdl.

Then the new testcase "tb_axi_stream.test back-to-back failing check" fails with questa, but not with ghdl. This is related to the setting-up of the logging mock. I played around a bit with the order of the delays and commands. It seems I can make it work with questa easily, but then it fails with ghdl.
I got the feeling that it depends on the scheduling of ready processes in one delta cycle...

@kraigher kraigher merged commit 3a3a6a8 into VUnit:master Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

axi_stream_slave with check function requires TREADY
2 participants