Fix PSL check for valid fifo in data during write, fixes #750 #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any reason you did not just use: assert always (not rst and wr -> is_x( d)@rising_edge(clkw) |
|
The reason was that I didn't remember that |
tmeissner
force-pushed
the
fix_array_axi_vcs_fifo_psl
branch
from
35a8986 to
481cfb3
Compare
|
Thanks! Jim for reporting and Torsten for fixing! ❤️ |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @JimLewis reported in #750 the result of the test if data is unknown during a FIFO write is not what we want in all cases. I fixed that by using the reduction
orin combination with theto_x01()function. That's also better readable code IMHO.