Complete A-CodeQuality #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser class: create functions to check for null task number and blank fields. Null task number and blank fields are handled in multiple switch cases, causing code duplication. Extracting the common error handling into its corresponding function allow us to reuse the code more efficiently. This also reduces the number of lines the parseCommand method have. Error handling for null task number is written in the checkNullTaskNum function. Error handling for blank fields i.e. descriptions, due date, start date, end date, keyword are written in the checkBlankField function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parser class: create functions to check for null task number and blank fields.
Null task number and blank fields are handled in multiple switch cases, causing code duplication.
Extracting the common error handling into its corresponding function allow us to reuse the code more efficiently. This also reduces the number of lines the parseCommand method have.
Error handling for null task number is written in the checkNullTaskNum function. Error handling for blank fields i.e. descriptions, due date, start date, end date, keyword are written in the checkBlankField function.