Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

requires numpy version 1.26.x (< 2.0) and appdirs module fix #65 #64 #66

Merged
merged 2 commits into from
Jul 20, 2024

Conversation

sonique6784
Copy link
Contributor

@sonique6784 sonique6784 commented Jul 6, 2024

yfinance-cache is not compatible with numpy 2.0.
making sure numpy 1.26 is installed
also requires appdirs and zoneinfo
fix #65 and #64

@sonique6784 sonique6784 mentioned this pull request Jul 6, 2024
@sonique6784 sonique6784 changed the title requires numpy version 1.26.x (< 2.0) fix #65 requires numpy version 1.26.x (< 2.0) and appdirs fix #65 #64 Jul 6, 2024
@sonique6784 sonique6784 changed the title requires numpy version 1.26.x (< 2.0) and appdirs fix #65 #64 requires numpy version 1.26.x (< 2.0), zoneinfo and appdirs fix #65 #64 Jul 6, 2024
@ValueRaider
Copy link
Owner

ValueRaider commented Jul 6, 2024

Just add a comment explaining why Numpy<2. Looks like Pandas install is hard-linked to Numpy 1

Edit: link to this: pandas-dev/pandas#59052

@sonique6784
Copy link
Contributor Author

sonique6784 commented Jul 7, 2024

Please see bug #65 for all details.
NumPy 2.0 was installed automatically with pandas 2.0.3 or maybe yfinance 0.2.40
here is the installed package list:

pip list            
Package               Version
--------------------- -----------
appdirs               1.4.4
beautifulsoup4        4.12.3
certifi               2024.7.4
charset-normalizer    3.3.2
click                 8.1.7
exchange_calendars    4.5.5
frozendict            2.4.4
html5lib              1.1
idna                  3.7
korean-lunar-calendar 0.3.1
lxml                  5.2.2
multitasking          0.0.11
numpy                 2.0
pandas                2.0.3
peewee                3.17.5
pip                   24.0
platformdirs          4.2.2
pyluach               2.2.0
python-dateutil       2.9.0.post0
pytz                  2024.1
requests              2.32.3
scipy                 1.13.1
setuptools            69.2.0
six                   1.16.0
soupsieve             2.5
toolz                 0.12.1
tzdata                2024.1
urllib3               2.2.2
webencodings          0.5.1
yfinance              0.2.40
yfinance-cache        0.6.4

@sonique6784 sonique6784 changed the title requires numpy version 1.26.x (< 2.0), zoneinfo and appdirs fix #65 #64 requires numpy version 1.26.x (< 2.0) and appdirs module fix #65 #64 Jul 7, 2024
@ValueRaider
Copy link
Owner

ValueRaider commented Jul 7, 2024

Btw, I'm currently testing if Pandas has really fixed their datetime bug pandas-dev/pandas#55487

@sonique6784
Copy link
Contributor Author

Thanks @ValueRaider. I set up a Linux docker and had the same issues:

  • appdirs
  • numpy < 2.0
  • python >3.9

So it would be safer for everyone to add those dependencies requirements

setup.cfg.template Outdated Show resolved Hide resolved
@sonique6784 sonique6784 requested a review from ValueRaider July 19, 2024 11:30
@ValueRaider
Copy link
Owner

Comment useless so I've redone it.

@ValueRaider ValueRaider merged commit 3c33de9 into ValueRaider:main Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

yfinance-cache not compatible with numpy 2.0, python >= 3.9 and appdirs dependencies
2 participants