[DO NOT MERGE][OD-1876] Auditfile report includes lines from inactive journals #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonioburic
changed the title
|
Added a small unit test checking the line count after archiving all journals. |
antonioburic
force-pushed
the
OD-1876/l10n_nl_xaf_auditfile_export/include_inactive_journals
branch
from
70c6ddd to
a898751
Compare
…als. [IMP] l10n_nl_xaf_auditfile_export: adding a simple test to include lines from inactive journals.
antonioburic
force-pushed
the
OD-1876/l10n_nl_xaf_auditfile_export/include_inactive_journals
branch
from
a898751 to
8790fd5
Compare
pankk
approved these changes
Mar 25, 2022
Thanks Kevin, I think so - the upstream PR fails in Travis but that's due to another module (l10n_nl_kvk). |
|
@antonioburic thanks! Can you create a buildout PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the contents of the auditfile complete as it includes the lines of inactive journals.
OCA PR towards 12.0: OCA#343