OD-2177/automate adyen bank statment import #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mileomai2008
force-pushed
the
OD-2177/automate_adyen_bank_statment_import
branch
from
cd7a2d4 to
9f3ad91
Compare
antonioburic
approved these changes
Oct 13, 2022
MPishpecki
reviewed
Oct 18, 2022
| @@ -50,6 +50,11 @@ def adyen_notification(self, **post): | |||
| # Handle the notification data | |||
| request.env['payment.transaction'].sudo().form_feedback( | |||
| post, 'adyen') | |||
| elif event_code == 'REPORT_AVAILABLE' and post['success'] == 'true': | |||
There was a problem hiding this comment.
this should cause conflict wthi this https://github.com/VanMoof/odoo/pull/5/files#diff-5c0cadcc807ef523fe18a7db4ef532cafab74bbf5a083f7c1a55e0b5ee3e4ff7R53
Maybe a good time to merge all cusomizatins for Adyen on odoo/odoo repository and bump up the hash?
| text=True, | ||
| shell=True | ||
| ) | ||
| std_out, std_err = process.communicate() |
There was a problem hiding this comment.
I dont see where we consume the report that comes back from Adyen?
I also dont see tests in our addons to cover this functionality.
dkubiak789
force-pushed
the
OD-2177/automate_adyen_bank_statment_import
branch
from
80314fd to
6ed8ac9
Compare
dkubiak789
force-pushed
the
OD-2177/automate_adyen_bank_statment_import
branch
from
2b099e4 to
daabc2d
Compare
dkubiak789
approved these changes
Oct 27, 2022
dkubiak789
force-pushed
the
OD-2177/automate_adyen_bank_statment_import
branch
from
daabc2d to
187bb3e
Compare
MPishpecki
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR: Doesn't handle 'REPORT_AVAILABLE' webhook
Desired behavior after PR is merged:
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr