-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial loongarch port #166
base: develop
Are you sure you want to change the base?
Conversation
Hi, thanks for your port to Loongson! I admit you beat me to it, I was looking forward to doing this myself! Thank you again! |
Hi @markos
You are welcome!
Yes, I am using the same working environment also for OpenJDK porting owing to I am a JDK 8 Updates Project Author.
And I am using LLVM toolchain for building vectorscan which depends on C++17 support.
And there is
OK. I will update my patch.
OK. Could you recommend which develop branch to rebase, for example, enable-fat-runtime-arm? Thanks, |
That's exactly the one, thanks again for your work! |
e4d82bf
to
8c036d6
Compare
Rebased! Thanks, |
Hi @markos Do I need to recreate a new PR for merging into VectorCamp:feature/enable-fat-runtime-arm? Thanks, |
No, you just need to change the target of the PR, but please hold on, I'm going to merge this soon to develop, so you can just edit this one. Give me a couple of days. |
8c036d6
to
7e1eb77
Compare
Hi @markos I rebased the initial loongarch port patch. Thanks, |
Hi @xiangzhai, I have finally setup my 3a5000 system and I was able to attempt to build your Pull Request. Unfortunately, the compiler tested (gcc 13 on Debian and Archlinux) do not hold this header: lsxintrin.h. So the build failed really early. After some research I realized that it's quite a bit early in terms of compiler support. Until this is finalized, I'm afraid I cannot test nor approve this Pull Request and it will have to wait. We can certainly revisit later of course, now that I have a working system I'm going to test this frequently for updates. |
Hi @markos
Yes, Let's wait upstream LSX/LASX support for LLVM toolchain. The reviewers are also code review the LLVM and GCC patchset for toolchains :)
You are welcome! Thanks, |
could you please set this PR against develop branch? Various changes were made in the CMake build system and this PR will have to be refactored. |
7e1eb77
to
2277a93
Compare
Hi @markos
Rebased! Passed unit-internal and unit-hyperscan tests. Thanks, |
Hi @markos
Upstreamed: https://github.com/llvm/llvm-project/blob/main/clang/lib/Headers/lsxintrin.h So you might test (clang or gcc on Debian and Archlinux) for it. Thanks, |
Co-authored-by: yangwenqing <yangwenqing@loongson.cn> Signed-off-by: Leslie Zhai <zhaixiang@loongson.cn> Signed-off-by: yangwenqing <yangwenqing@loongson.cn>
2277a93
to
6255055
Compare
Hi @markos Could you review the patch? Thanks, |
@xiangzhai not until lsxintrin.h is in a package in Debian for either clang or gcc. Until that happens, I cannot merge LSX support. I just tested gcc-13 and clang-17, they still don't have that file in Debian packages. |
I added some review comments, which should be easy to fix until we can actually do a proper review when compiler support arrives. Thanks for your patience in this. |
Move ARCH_C_FLAGS and ARCH_CXX_FLAGS to LoongArch respective cmake file. Move vpmax_loongarch to loongarch64/simd_utils.h.
Hi @markos Thanks for your careful review! I updated my patch as your suggestion. Thanks, |
Hi @markos
Please update to install clang-18, there is Thanks, |
Hi @xiangzhai |
https://github.com/loongson/Firmware/tree/main/5000Series/PC |
Indeed, that's where I got it from, I just forgot to download the 'raw' binary. In any case, I need to figure out how to connect a JTAG or similar adaptor and upload the UEFI image using SPI. Currently it just gives a constant beep and fails to do anything else -no UEFI Shell/BIOS screen or anything else. |
Hi @markos Could you try qemu system loongarch64 if your working environment was broken please? Thanks, |
Even if it builds on qemu -which is not something I have the time to do- we would not merge the PR as we would not be able to support it in our CI. It is in the immediate plans to either fix the system or get a new one. Just be patient please. |
Hi,
I want to port vectorscan AKA hyperscan for LoongArch Architecture.
Passed unit-internal test:
Passed unit-hyperscan test:
Thanks,
Leslie Zhai