Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ubuntu 20.04 gcc does not define HWCAP2_SVE2 #180 #186

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

markos
Copy link

@markos markos commented Oct 10, 2023

Gcc on Ubuntu 20.04 does not define HWCAP2 defines, incl. HWCAP2_SVE2.
We suggest this patch to enable integration of Vectorscan on Envoyproxy on non-x86 platforms:

envoyproxy/envoy#29881

@markos markos linked an issue Oct 10, 2023 that may be closed by this pull request
@sambercovici
Copy link

tested with clan 10 and gcc 9.4.0

cmake --version
cmake version 3.27.7

git checkout bugfix/fix-compilation-arm-ubuntu-20.04

  1. sqlite detection fails
    cmake --fresh .. -DBOOST_ROOT=/home/ubuntu/boost_1_57_0 -DCMAKE_BUILD_TYPE=Release
    fails:
    CMake Error at cmake/sqlite3.cmake:24 (list):
    list sub-command INSERT requires at least three arguments.
    Call Stack (most recent call first):
    tools/hsbench/CMakeLists.txt:1 (include)

commented line 24 in cmake/sqlite3.cmake

cmake --fresh .. -DBOOST_ROOT=/home/ubuntu/boost_1_57_0 -DCMAKE_BUILD_TYPE=Release

make hs_runtime
OK

@markos
Copy link
Author

markos commented Oct 11, 2023

hm, I see the problem, it tries to use pkg-config to find the sqlite variables and fails. Could you try installing pkg-config and libsqlite3-dev and retry? I'll fix it in a new commit, but I think that should do it.

@sambercovici
Copy link

this worked

@sambercovici
Copy link

Hi @markos,
Anything else?
Is there an ETA for the next release that will build on Ubuntu 20.04?

@markos
Copy link
Author

markos commented Oct 19, 2023

@sambercovici I'm working on fixing an SVE2-related segfault right now, the next release should hopefully be done by the end of this month.

@sambercovici
Copy link

Hi @markos is this till on track?

@markos
Copy link
Author

markos commented Oct 25, 2023

@sambercovici the release will be done by the end of the month, yes. this will go in.

@markos markos merged commit de94286 into develop Oct 25, 2023
@markos
Copy link
Author

markos commented Oct 25, 2023

The sqlite fix will go in a different PR

@markos markos deleted the bugfix/fix-compilation-arm-ubuntu-20.04 branch May 22, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support building on Ubuntu 20.04
2 participants