Teddy macros unrolling - initial PR to test in CI #294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 19 commits
May 27, 2024 14:54
some tests are failing so something isn't right in here..
helps failing tests.
will be an intermediate step toward templetizing all this.
build but of course not yet actually used by anything.
markos
reviewed
Jun 26, 2024
markos
reviewed
Jun 26, 2024
markos
reviewed
Jun 26, 2024
markos
reviewed
Jun 26, 2024
markos
reviewed
Jun 26, 2024
markos
reviewed
Jun 26, 2024
markos
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unrolling the complicated macros in fdr/teddy.c which are opaque to debugging.
There's reason to believe there is some legacy cruft hiding in parts of this but for now
the functionization has been kept pretty much a direct copy.
While the objective of this PR is maintainability and manageability of the codebase,
there have been a few positive side-effects on performance. specifically performance in SSE2 , AVX512 , and ppc
environments has seen a very slight boost (between 0.1% - 0.5% improvement). performance in other environments is essentially unchanged.